What happens if I have a track named "Some Track (Some Artist Re-Mix).mp3"? I think we should not parse artist-title with a single dash. No magic is far better than broken magic. The person could just tag the files correctly or use perl-rename 's/-/ - /g' *.mp3.

Now we have a complain that "artist-title" is not supported which was the 2.2 state. We had never complains about false positives.
From this point of view let's merge it.

Importing "Some Track (Some Artist Re-Mix).mp3" as Artist: "Some Track (Some Artist Re" Track: "Mix" is probably also not too bad, because you need to adjust the naming anyway.

What do you think?

Importing "Some Track (Some Artist Re-Mix).mp3" as Artist: "Some Track (Some Artist Re" Track: "Mix" is probably also not too bad, because you need to adjust the naming anyway

Why do you need to adjust the naming anyway? I think that broken parsing is way worse than no parsing at all (even in the artist-title case).

Why do you need to adjust the naming anyway?

Because else I have Title and artist in the title field.

This is finally a personal preference we can't solve in a discussion. I always use spaces, so I don't really mind.
Has this really append to you or is it an artificial example.

The valid argument to me here is that this was reported as a regression and the regression is fixed with this PR.

Why do you need to adjust the naming anyway?

Because else I have Title and artist in the title field.

No, you only have the title in the title field and no artist at all (as there is no artist is in the filename).

This is finally a personal preference we can't solve in a discussion. I always use spaces, so I don't really mind.

How you name your files is indeed personal preference. Mixxx making wrong assumptions about the file name and applying broken magic where it shouldn't is not personal preference.

Has this really append to you or is it an artificial example.

This is an artificial example because I always tag my files, but AFAIK the default naming scheme for iTunes looks like this: 2-01 Take On Me [Demo Version].mp3, so it's definitely not far-fetched.

I think it's reasonable to assume - (with spaces) separates artist and title, but we don't have enough information to assume that - (without spaces) is the artist/title separator.

The valid argument to me here is that this was reported as a regression and the regression is fixed with this PR.

It's a regression in so far as previous behavior has changed. The original behavior was wrong and I'd consider it a bug. I think it's reasonable to ask the reporter to either fix their file names/tags or live without the magic artist/title parsing.

The original behavior was wrong and I'd consider it a bug

The point is, that we have no evidence for this but for the opposite.

...and those discussions show once again why adding this "feature" in the first place was a bad idea.

I always wanted to delete the code, even if users might complain. Most of them are not even aware that there are better ways for managing metdata. Mixxx prevents them from realizing this.

???

I vote for merge, the work is done and one user will be happy.

I'm not happy about this. If you really think this is needed instead of users just fixing their tags or naming scheme (which can easily be done with a bulk rename, e. g. using find ~/Music -type f - i name "*.mp3" - exec perl-rename 's/^([^-]+[^ ])-([^ ].*)$/\1 - \2/' {} \;), then we should at least add additional checks to reduce the likelihood of false positives:

1. The dash must not appear inside parentheses (()) or brackets ([]) to prevent splitting track titles like Foo (Bar Re-Mix).mp3
2. The dash must not be surrounded with numbers to prevent splitting filenames like 1-2 Some Track.mp3 (default iTunes naming scheme for track 2 on disk 1 of a multi disk album).

Even with these additional rules, I doubt that it is worth it to introduce this complexity (which might still fail to detect undesired splitting) when the user could just fix the naming of the files with minimal effort. But if you deem it necessary I won't vote against the merge then.

My preferred solution would be to just use the file name excluding the last suffix as the title and get rid of this poor parser.